lkml.org 
[lkml]   [2010]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFCv3 00/21] TCM Core and TCM_Loop patches for v2.6.37

Some comments on the configfs to backend API:

- the various get_*_info methods look like they really should use
the seq_file API. That gives you safety against overflows,
and simplifies the code.
- why are show_configfs_dev_params and get_dev_info separate
methods if they always end up calling the same code?
- the set_configfs_dev_params method implementation contains some
rather nast parsing code. They look like they really should use
the parser.h helpers we use for mount option parsing.


\
 
 \ /
  Last update: 2010-11-08 15:43    [W:0.106 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site