Messages in this thread | | | Date | Mon, 8 Nov 2010 09:39:52 -0500 | From | Christoph Hellwig <> | Subject | Re: [RFCv3 00/21] TCM Core and TCM_Loop patches for v2.6.37 |
| |
Some comments on the configfs to backend API:
- the various get_*_info methods look like they really should use the seq_file API. That gives you safety against overflows, and simplifies the code. - why are show_configfs_dev_params and get_dev_info separate methods if they always end up calling the same code? - the set_configfs_dev_params method implementation contains some rather nast parsing code. They look like they really should use the parser.h helpers we use for mount option parsing.
| |