lkml.org 
[lkml]   [2010]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure
On Sun, 7 Nov 2010, Frank Mori Hess wrote:

> On Sunday 07 November 2010, Jesper Juhl wrote:
> > Hi,
> >
> > In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many
> > potential failure scenarios. However, the driver neglects to free
> > resources it has allocated if failures happen.
>
> This patch appears to be wrong. The driver's detach function will be
> called by the core if the attach function returns with an error. The
> resources are freed there.
>
Ohh, sorry, I did not realize that.
In that case, please disregard this patch.


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2010-11-08 00:49    [W:0.025 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site