Messages in this thread | | | Date | Mon, 8 Nov 2010 00:34:56 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure |
| |
On Sun, 7 Nov 2010, Frank Mori Hess wrote:
> On Sunday 07 November 2010, Jesper Juhl wrote: > > Hi, > > > > In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many > > potential failure scenarios. However, the driver neglects to free > > resources it has allocated if failures happen. > > This patch appears to be wrong. The driver's detach function will be > called by the core if the attach function returns with an error. The > resources are freed there. > Ohh, sorry, I did not realize that. In that case, please disregard this patch.
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please.
| |