lkml.org 
[lkml]   [2010]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure
Date
On Sunday 07 November 2010, Jesper Juhl wrote:
> Hi,
>
> In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many
> potential failure scenarios. However, the driver neglects to free
> resources it has allocated if failures happen.

This patch appears to be wrong. The driver's detach function will be
called by the core if the attach function returns with an error. The
resources are freed there.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-11-08 00:45    [W:0.654 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site