Messages in this thread | | | From | Frank Mori Hess <> | Subject | Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure | Date | Sun, 7 Nov 2010 18:35:23 -0500 |
| |
On Sunday 07 November 2010, Jesper Juhl wrote: > Hi, > > In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many > potential failure scenarios. However, the driver neglects to free > resources it has allocated if failures happen.
This patch appears to be wrong. The driver's detach function will be called by the core if the attach function returns with an error. The resources are freed there.
[unhandled content-type:application/pgp-signature] | |