Messages in this thread | | | Date | Wed, 3 Nov 2010 14:12:37 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/1] console: add /proc/consoles |
| |
On Wed, Nov 03, 2010 at 09:03:42PM +0100, Jiri Slaby wrote: > On 11/03/2010 06:39 PM, Greg KH wrote: > > On Wed, Nov 03, 2010 at 05:25:32PM +0100, Jiri Slaby wrote: > >> Actually where this code should be in fs/proc/? Most of the /proc/* is > >> handled elsewhere (fs/ mm/ kernel/). The rest is handled in specialized > >> fs/proc/FILE.c. > > > > What's wrong with putting it into fs/proc/proc_tty.c? That seems like > > the most logical thing to me... > > consoles have little to do with ttys. Except ttys can be consoles.
And all consoles are ttys :)
> To me > it seems illogical to have info about netconsole, parallel consoles or > early serials somewhere in /proc/tty/. That's why I moved the info from > /proc/tty/ to /proc and the code from fs/proc/proc_tty.c to > kernel/printk.c where consoles are managed.
Ok, how about fs/proc/proc_console.c instead?
And no, printk.c is not the most logical place for something like this. If I see a proc file, I am not going to automatically assume that printk.c would have anything to do with it. As it really doesn't (printk goes to the kernel log buffer, not a console).
thanks,
greg k-h
| |