lkml.org 
[lkml]   [2010]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] console: add /proc/consoles
On 11/03/2010 06:39 PM, Greg KH wrote:
> On Wed, Nov 03, 2010 at 05:25:32PM +0100, Jiri Slaby wrote:
>> Actually where this code should be in fs/proc/? Most of the /proc/* is
>> handled elsewhere (fs/ mm/ kernel/). The rest is handled in specialized
>> fs/proc/FILE.c.
>
> What's wrong with putting it into fs/proc/proc_tty.c? That seems like
> the most logical thing to me...

consoles have little to do with ttys. Except ttys can be consoles. To me
it seems illogical to have info about netconsole, parallel consoles or
early serials somewhere in /proc/tty/. That's why I moved the info from
/proc/tty/ to /proc and the code from fs/proc/proc_tty.c to
kernel/printk.c where consoles are managed.

But if that makes less sense now than it did before, I will happily
switch it back.

regards,
--
js


\
 
 \ /
  Last update: 2010-11-03 21:07    [W:0.052 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site