Messages in this thread | | | Date | Wed, 3 Nov 2010 22:15:29 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. |
| |
On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:
> @@ -4169,13 +4169,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node) > */ > if (!node_state(node, N_NORMAL_MEMORY)) > tmp = -1; > - pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, tmp); > + pn = kmalloc_node(sizeof(*pn), GFP_KERNEL|__GFP_ZERO, tmp);
Use the simpler kzalloc_node()? It's introduced here:
commit 979b0fea2d9ae5d57237a368d571cbc84655fba6 Author: Jeff Layton <jlayton@redhat.com> Date: Thu Jun 5 22:47:00 2008 -0700
vm: add kzalloc_node() inline
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
Thanks, Fengguang
| |