lkml.org 
[lkml]   [2010]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:
> On Mon, 1 Nov 2010, Johannes Weiner wrote:
>
> > On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote:
> > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then
> > > followed by memset() to zero the memory. This can be more efficiently
> > > achieved by using kzalloc() and vzalloc().
> > >
> > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> >
> > Looks good to me, but there is also the memset after kmalloc in
> > alloc_mem_cgroup_per_zone_info(). Can you switch that over as well
> > in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing.
>
> Sure thing.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thanks.

Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>


\
 
 \ /
  Last update: 2010-11-02 13:27    [W:0.206 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site