Messages in this thread Patch in this message | | | Subject | [PATCH 2.6.37] led_class: fix typo in blink API | From | Johannes Berg <> | Date | Sat, 27 Nov 2010 19:42:08 +0100 |
| |
From: Johannes Berg <johannes.berg@intel.com>
When I added led_blink_set I had a typo: the return value of the hw offload is a regular error code that is zero when succesful, and in that case software emulation should not be used, rather than the other way around.
Signed-off-by: Johannes Berg <johannes.berg@intel.com> --- It'd be nice to get this into 2.6.37 since the patch that has the bug is in there. Sorry about that -- I had tested the software implementation extensively but apparently never tested the hw offload part.
drivers/leds/led-class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- wireless-testing.orig/drivers/leds/led-class.c 2010-11-27 19:32:24.000000000 +0100 +++ wireless-testing/drivers/leds/led-class.c 2010-11-27 19:35:41.000000000 +0100 @@ -267,7 +267,7 @@ void led_blink_set(struct led_classdev * unsigned long *delay_off) { if (led_cdev->blink_set && - led_cdev->blink_set(led_cdev, delay_on, delay_off)) + !led_cdev->blink_set(led_cdev, delay_on, delay_off)) return; /* blink with 1 Hz as default if nothing specified */
| |