lkml.org 
[lkml]   [2010]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] debug_core: cleanup kgdb_cpu_enter() that removing smp_mb()
Date
Commit dfee3a7b92208b30f77876068aece9ea571270c2(debug_core:
refactor locking for master/slave cpus) uses spin_lock to replace
the atomic counter lock mechanism, and most kgdb data was designed
to per-cpu, thus the 'smp_mb()' operation is useless here now.

Signed-off-by: Dongdong Deng <libfetion@gmail.com>
---
kernel/debug/debug_core.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 722968f..1b019b5 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -492,9 +492,6 @@ acquirelock:
kgdb_info[cpu].ret_state = 0;
kgdb_info[cpu].irq_depth = hardirq_count() >> HARDIRQ_SHIFT;

- /* Make sure the above info reaches the primary CPU */
- smp_mb();
-
if (exception_level == 1) {
if (raw_spin_trylock(&dbg_master_lock))
atomic_xchg(&kgdb_active, cpu);
--
1.6.0.4


\
 
 \ /
  Last update: 2010-11-26 10:15    [W:0.016 / U:2.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site