Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 03/14] freezer: remove superflous try_to_freeze() loop in do_signal_stop() | Date | Fri, 26 Nov 2010 20:42:21 +0100 |
| |
On Friday, November 26, 2010, Tejun Heo wrote: > do_signal_stop() is used only by get_signal_to_deliver() and after a > successful signal stop, it always calls try_to_freeze(), so the > try_to_freeze() loop around schedule() in do_signal_stop() is > superflous and confusing. Remove it. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Oleg Nesterov <oleg@redhat.com> > Cc: Roland McGrath <roland@redhat.com> > Cc: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Thanks!
> --- > kernel/signal.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/kernel/signal.c b/kernel/signal.c > index fe004b5..0a6816a 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -1781,9 +1781,7 @@ static int do_signal_stop(int signr) > } > > /* Now we don't run again until woken by SIGCONT or SIGKILL */ > - do { > - schedule(); > - } while (try_to_freeze()); > + schedule(); > > tracehook_finish_jctl(); > current->exit_code = 0; >
| |