Messages in this thread | | | Date | Mon, 29 Nov 2010 14:38:30 +0100 | From | Tejun Heo <> | Subject | Re: [PATCH UPDATED 06/14] signal: use GROUP_STOP_PENDING to avoid stopping multiple times for a single group stop |
| |
Hello, Oleg.
On 11/28/2010 08:07 PM, Oleg Nesterov wrote: >> @@ -732,6 +732,9 @@ static int prepare_signal(int sig, struct task_struct *p, int from_ancestor_ns) >> t = p; >> do { >> unsigned int state; >> + >> + t->group_stop = 0; >> + > > Yes. > > But, afaics, this is not enough. Say, what about zap_other_threads() ? > We shouldn't allow sub-threads to stop in this case. > > Basically, every time we clear ->group_stop_count we should also reset > ->group_stop for every thread. Fortunately, every time we already do > while_each_thread().
Yes, indeed. Will update accordingly.
Thanks.
-- tejun
| |