Messages in this thread Patch in this message | | | From | Alexander Gordeev <> | Subject | [PATCHv5 10/17] pps: use BUG_ON for kernel API safety checks | Date | Wed, 24 Nov 2010 19:15:48 +0300 |
| |
This way less overhead is involved when running production kernel. If you want to debug a pps client module please define DEBUG to enable the checks.
Acked-by: Rodolfo Giometti <giometti@linux.it> Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su> --- drivers/pps/kapi.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c index c42d3cb..3e8eb3f 100644 --- a/drivers/pps/kapi.c +++ b/drivers/pps/kapi.c @@ -166,10 +166,8 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event, int captured = 0; struct pps_ktime ts_real; - if ((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0) { - dev_err(pps->dev, "unknown event (%x)\n", event); - return; - } + /* check event type */ + BUG_ON((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0); dev_dbg(pps->dev, "PPS event at %ld.%09ld\n", ts->ts_real.tv_sec, ts->ts_real.tv_nsec); -- 1.7.2.3
| |