lkml.org 
[lkml]   [2010]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] regulator: Fix obfuscated log messages
Date
Don't use %s to format fixed static strings into log messages, it just
makes searching for and reading the message in the kernel source
needlessly hard.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/core.c | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 8d492f4..fe47860 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -760,7 +760,7 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,

/* else require explicit machine-level constraints */
if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
- pr_err("%s '%s' voltage constraints\n", "invalid",
+ pr_err("invalid '%s' voltage constraints\n",
name);
return -EINVAL;
}
@@ -782,22 +782,20 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,

/* final: [min_uV..max_uV] valid iff constraints valid */
if (max_uV < min_uV) {
- pr_err("%s '%s' voltage constraints\n", "unsupportable",
+ pr_err("unsupportable '%s' voltage constraints\n",
name);
return -EINVAL;
}

/* use regulator's subset of machine constraints */
if (constraints->min_uV < min_uV) {
- pr_debug("override '%s' %s, %d -> %d\n",
- name, "min_uV",
- constraints->min_uV, min_uV);
+ pr_debug("override '%s' min_uV, %d -> %d\n",
+ name, constraints->min_uV, min_uV);
constraints->min_uV = min_uV;
}
if (constraints->max_uV > max_uV) {
- pr_debug("override '%s' %s, %d -> %d\n",
- name, "max_uV",
- constraints->max_uV, max_uV);
+ pr_debug("override '%s' max_uV, %d -> %d\n",
+ name, constraints->max_uV, max_uV);
constraints->max_uV = max_uV;
}
}
--
1.7.1


\
 
 \ /
  Last update: 2010-11-22 14:53    [W:0.103 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site