Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 Nov 2010 09:16:26 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n |
| |
On Mon, 15 Nov 2010, Linus Torvalds wrote:
> On Mon, Nov 15, 2010 at 9:34 AM, Eric Paris <eparis@parisplace.org> wrote: > > > > I'm sure somebody somewhere hates it, but I was thinking something > > like the attached. > > I certainly like it. If the old rule should have been that you _have_ > to call cap_syslog(), then just eviscerating that entirely and putting > it in the generic code is definitely the right thing. > > Anyway, I wanted to do -rc2 yesterday, but I don't really want this > kernel build problem to remain (even if it's not a very relevant > config for most people). > > So if people can quickly agree on this, I'll take it and do -rc2 later > today, otherwise I'll do Joe's trivial patch as a stop-gap measure > pending approval for cleanup/fixing the security interfaces.
Looks good to me:
Acked-by: James Morris <jmorris@namei.org>
(I'd really like to see new security features get fully reviewed on the LSM list and bake in -next for a while in the future, no matter how obviously correct they seem).
-- James Morris <jmorris@namei.org>
| ![\](/images/icornerr.gif) |