Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 15 Nov 2010 12:45:28 -0500 | Subject | Re: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n | From | Eric Paris <> |
| |
On Mon, Nov 15, 2010 at 12:41 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > If the old rule should have been that you _have_ > to call cap_syslog(), then just eviscerating that entirely and putting > it in the generic code is definitely the right thing.
That is the rule for ALL of the hooks in commoncap.c. The one time I tried to do something else *cough*mmap_min_addr*cough* I screwed it up. I'll put a note in my todo list about looking into lifting all of commoncap.c into the callers.
-Eric
| ![\](/images/icornerr.gif) |