lkml.org 
[lkml]   [2010]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device()
Hello,

On 11/13/2010 11:38 AM, Artem Bityutskiy wrote:
> On Mon, 2010-11-01 at 17:15 +0100, Tejun Heo wrote:
>> + if (!IS_ERR(bdev)) {
>> + int ret;
>> + ret = bd_claim(bdev, dev);
>> + if (ret) {
>> + blkdev_put(bdev,
>> + FMODE_READ | FMODE_WRITE);
>
> Would be a bit cleaner to define ea temporary variable:
>
> fmode_t mode = FMODE_READ | FMODE_WRITE;
>
> Would you to re-send with this little change please?

Yeap, sure.

> And ideally, 2 independent patches would be nicer because you fix 2
> independent issues.

Hmmm... not really. The patch is small enough and splitting it won't
really buy as any better bisectability. Splitting patches into
logical changes is a good thing but it's no religious dogma. Let's
apply it to the point it actually helps.

Thank you.

--
tejun


\
 
 \ /
  Last update: 2010-11-13 11:47    [W:3.948 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site