Messages in this thread | | | Date | Sat, 13 Nov 2010 12:18:03 +0100 | From | Tejun Heo <> | Subject | Re: [PATCH UPDATED 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device() |
| |
Hello,
On 11/13/2010 12:14 PM, Artem Bityutskiy wrote: > On Sat, 2010-11-13 at 11:59 +0100, Tejun Heo wrote: >> There are two bdev exclusive open bugs. >> >> * open_bdev_exclusive() must not be called with NULL holder. Use dev >> as the holder. >> >> * open_by_devnum() doesn't open the bdev exclusively but >> block2mtd_free_device() always assumes it. Explicitly claim the >> bdev. >> >> The latter is rather clumsy but will be simplified with future >> blkdev_get/put() cleanups. >> >> - Updated to use local variable @mode to cache FMODE_* masks as >> suggested by Artem Bityutskiy. > > Do you want this patch to go in via Jens' tree with the rest of the > series, or as an independent patch via the mtd tree?
It probably would be easier if this is routed through Jens' tree as it's necessary for later patches in the series, but this being a fix, this should be merged during this cycle rather than the next one. Jens, how do you want to proceed?
Thank you.
-- tejun
| |