Messages in this thread | | | Date | Thu, 11 Nov 2010 21:12:59 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 2/3] perf: Add support for extra parameters for raw events |
| |
On Thu, Nov 11, 2010 at 08:59:47PM +0100, Peter Zijlstra wrote: > On Thu, 2010-11-11 at 20:49 +0100, Andi Kleen wrote: > > > I think it would have parsed OK, but it is a confusing syntax to > > > look at. I should point out that there are also the u,k,h modifiers > > > which can be specified, even on raw events, so the full syntax looks > > > something like: > > > > > > -e rXXXX[+YYYY][:u|:k|:h] > > > > Ok I can fix the help text for that. > > If we're frobbing it in the existing config qword, do we still need > special syntax?
No, it could be all merged then.
> > Also, I think we can use the same mechanism to program the > PEBS-load-latency MSR, right?
I haven't looked at that, but if it's a per core resource the infrastructure can be reused at least.
-Andi -- ak@linux.intel.com -- Speaking for myself only.
| |