Messages in this thread | | | Date | Wed, 30 Sep 2009 12:28:23 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used |
| |
O> Also, does it matter if someone issues TIOCGPTN on a legacy pty master? There > is a number in tty->index that can be returned. If it can, then
Not a lot - providing someone isn't using it as a way to tell pty types apart (which I have seen done in example code)
> pty_bsd_ioctl() can be merged with pty_unix98_ioctl(), and possibly both > ioctls can be given to the generic tty ioctl handling
I would keep
if (type == FOO)
as far away from the generic tty ioctl code as possible. It's already convoluted and complex with zillions of ioctl calls. Separating out lots of the console and other ioctls properly cleaned it up no end and going backwards would be a bad mistake.
| |