Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used | Date | Wed, 30 Sep 2009 11:20:00 +0100 |
| |
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> So I do wonder whether the right thing to do would not be to simple remove > the whole pty_ops_bsd code entirely. Or maybe mode the trivial TIOCSPTLCK > into the generic tty ioctl handling, and just make it test for > "driver->subtype == PTY_TYPE_MASTER" - and at least get rid of this subtle > thing that was broken for over a year without anybody noticing..
Also, does it matter if someone issues TIOCGPTN on a legacy pty master? There is a number in tty->index that can be returned. If it can, then pty_bsd_ioctl() can be merged with pty_unix98_ioctl(), and possibly both ioctls can be given to the generic tty ioctl handling with the condition that driver->subtype == PTY_TYPE_MASTER.
David
| |