Messages in this thread | | | Date | Tue, 22 Sep 2009 09:16:20 +0200 | From | Arjan van de Ven <> | Subject | Re: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2) |
| |
On Mon, 21 Sep 2009 23:37:01 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote: > > - dev->current_state = state; > + pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); > + dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK); > + /* Return error code if we have failed to change the state */ > + if (dev->current_state != state) > + dev_info(&dev->dev, "Refused to change power state, " > + "currently in D%d\n", dev->current_state);
I would suspect that you want this message only once... to avoid it flooding logs and such
or at least ratelimiting it
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |