Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2) | Date | Tue, 22 Sep 2009 22:39:08 +0200 |
| |
On Tuesday 22 September 2009, kevin granade wrote: > On Tue, Sep 22, 2009 at 2:50 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > > On Tuesday 22 September 2009, Andreas Mohr wrote: > > > Hi Rafael, > > > > Hi, > > > > > first you say "returning an error code in such cases would..." > > > and then the patch content has...? > > > > I don't quite understand your comment, care to elaborate? > > > > > I think this is what was being referenced: > > + /* Return error code if we have failed to change the state */ > + if (dev->current_state != state) > + dev_info(&dev->dev, "Refused to change power state, " > + "currently in D%d\n", dev->current_state); > > The comment says, "Return error code", where it should probably say, "Log > error". Or possibly no comment at all.
Ah, thanks.
Rafael
| |