lkml.org 
[lkml]   [2009]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2)
Date
On Tuesday 22 September 2009, kevin granade wrote:
> On Tue, Sep 22, 2009 at 2:50 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> > On Tuesday 22 September 2009, Andreas Mohr wrote:
> > > Hi Rafael,
> >
> > Hi,
> >
> > > first you say "returning an error code in such cases would..."
> > > and then the patch content has...?
> >
> > I don't quite understand your comment, care to elaborate?
> >
> >
> I think this is what was being referenced:
>
> + /* Return error code if we have failed to change the state */
> + if (dev->current_state != state)
> + dev_info(&dev->dev, "Refused to change power state, "
> + "currently in D%d\n", dev->current_state);
>
> The comment says, "Return error code", where it should probably say, "Log
> error". Or possibly no comment at all.

Ah, thanks.

Rafael


\
 
 \ /
  Last update: 2009-09-22 22:41    [W:0.068 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site