lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/4] vfs: change sb->s_maxbytes to loff_t
Date
Recently, I spent a day or so tracking down a long-standing problem with
CIFS and sendfile(). The problem turned out to be that CIFS was setting
s_maxbytes to a value that, when cast to a signed value, became
negative. This broke the offset checks in do_sendfile().

While I fixed this in CIFS, it turns out that this problem is actually a
little more widespread. Since setting s_maxbytes to a value larger than
MAX_LFS_FILESIZE breaks things, I believe it makes sense to turn
s_maxbytes into an loff_t. Most of the places that compare values to
s_maxbytes are comparing it against signed loff_t values, so this change
should help reduce the amount of implicit casting that's done in the
code.

I've looked at most of the places that use s_maxbytes and have tried to
fix areas that look like they might have problems with this change. It's
quite possible though that I've missed some, so a careful eye for that
when reviewing this would be a good thing.

This set is only lightly tested, but it's fairly straightforward.

Jeff Layton (4):
vfs: make get_sb_pseudo set s_maxbytes to value that can be cast to
signed
vfs: explicitly cast s_maxbytes in fiemap_check_ranges
vfs: change sb->s_maxbytes to a loff_t
vfs: remove redundant checks in do_sendfile

fs/ioctl.c | 9 +++++----
fs/libfs.c | 2 +-
fs/read_write.c | 11 -----------
fs/super.c | 10 ++++++++++
include/linux/fs.h | 2 +-
5 files changed, 17 insertions(+), 17 deletions(-)



\
 
 \ /
  Last update: 2009-08-07 21:01    [W:0.074 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site