Messages in this thread | | | Date | Thu, 06 Aug 2009 17:13:31 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev() |
| |
Tejun Heo wrote: > Hello, > > Greg KH wrote: >> Yes the names are confusing, the whole api needs a rework to make it >> easier to understand :( > > For now, I'll open code it then but it would be really nice to clean > the names up.
Crap, there's a difference. For [un]register_chrdev() the chrdev layer keeps track of cdev while using cdev_alloc/add/del() directly requires the caller to keep track of the pointer. Also, it's a bit of pain to open code the whole thing.
For now, it looks like adding the __ prefixed versions seems to be the proper solution. It's strange to provide the helper interface only for full minor acquisitions anyway. Let's do naming cleanup later. How does that sound?
Thanks.
-- tejun
| |