Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 6 Aug 2009 12:58:48 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev() |
| |
On Thu, Aug 06, 2009 at 05:13:31PM +0900, Tejun Heo wrote: > Tejun Heo wrote: > > Hello, > > > > Greg KH wrote: > >> Yes the names are confusing, the whole api needs a rework to make it > >> easier to understand :( > > > > For now, I'll open code it then but it would be really nice to clean > > the names up. > > Crap, there's a difference. For [un]register_chrdev() the chrdev > layer keeps track of cdev while using cdev_alloc/add/del() directly > requires the caller to keep track of the pointer. Also, it's a bit of > pain to open code the whole thing. > > For now, it looks like adding the __ prefixed versions seems to be the > proper solution. It's strange to provide the helper interface only > for full minor acquisitions anyway. Let's do naming cleanup later. > How does that sound?
Well, what's the odds that I can get you to do cleanup now? :)
Sure, I'll take this, only if Takashi wants the other stuff that depends on it. Let me know.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |