Messages in this thread | | | Date | Thu, 6 Aug 2009 23:07:33 -0400 (EDT) | From | Nicolas Pitre <> | Subject | Re: [PATCH] [ARM] Kirkwood: Marvell OpenRD-Base board support added to v2.6.31-rc5 |
| |
On Thu, 6 Aug 2009, Ben Dooks wrote:
> On Thu, Aug 06, 2009 at 07:39:13PM +0530, Dhaval Vasa wrote: > > reference: > > http://open-rd.org > > http://code.google.com/p/openrd > > > > This patch is tested for: > > 1. Boot from DRAM/NAND flash > > 2. NAND read/write/erase > > 3. GbE0 > > 4. USB read/write > > > > FIXME: > > 1. SD/UART1 selection > > 2. MPP configuration (currently, default) > > 3. PEX > > > > Signed-off-by: Dhaval Vasa <dhaval.vasa@einfochips.com> > > You forgot to cc: linux-arm-kernel@lists.arm.linux.org.uk, although > someone really should issue a MAINTAINERS entry for that machine > directory.
Yep, I'll take care of it.
> > --- > > arch/arm/mach-kirkwood/Kconfig | 5 ++ > > arch/arm/mach-kirkwood/Makefile | 1 + > > arch/arm/mach-kirkwood/openrd_base-setup.c | 79 ++++++++++++++++++++++++++++ > > 3 files changed, 85 insertions(+), 0 deletions(-) > > create mode 100644 arch/arm/mach-kirkwood/openrd_base-setup.c > > call this openrd.c or openrd_base.c, the -setup is redundant as > these directories are suposed to have the machine setup files in > them.
The *-setup.c is the existing naming sheme used for the Orion and Kirkwood architectures to contain board setup code instead of common IRQ or timer code for example. So it is fine.
Nicolas
| |