Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Linus Walleij <> | Subject | [PATCH] REGULATOR Handle positive returncode from enable | Date | Wed, 26 Aug 2009 12:54:04 +0200 |
| |
This makes _regulator_enable() properly handle the case where a regulator is already on when you try to enable it. Currently it will erroneously handle positive return values as an error.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com> --- drivers/regulator/core.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index dbf27bf..744ea1d 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1236,11 +1236,12 @@ static int _regulator_enable(struct regulator_dev *rdev) } else { return -EINVAL; } - } else { + } else if (ret < 0) { printk(KERN_ERR "%s: is_enabled() failed for %s: %d\n", __func__, rdev->desc->name, ret); return ret; } + /* Fallthrough on positive return values - already enabled */ } rdev->use_count++; -- 1.6.2.1
| ![\](/images/icornerr.gif) |