lkml.org 
[lkml]   [2009]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: fix calculation of voltage range in da9034_set_ldo12_voltage()
On Tue, Aug 25, 2009 at 03:42:00PM +0200, Roel Kluin wrote:
> For val to be greater than 7 or less than 20 is logically always true.

> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Looks good to me but CCing in Eric and Mike just in case the intent of
the code was something other than the new version.

> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index b8b89ef..2d9bde5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -278,7 +278,7 @@ static int da9034_set_ldo12_voltage(struct regulator_dev *rdev,
> }
>
> val = (min_uV - info->min_uV + info->step_uV - 1) / info->step_uV;
> - val = (val > 7 || val < 20) ? 8 : val - 12;
> + val = (val > 7 && val < 20) ? 8 : val - 12;
> val <<= info->vol_shift;
> mask = ((1 << info->vol_nbits) - 1) << info->vol_shift;
>


\
 
 \ /
  Last update: 2009-08-25 20:43    [W:0.040 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site