Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Wed, 03 Jun 2009 00:57:20 +0200 | From | Roel Kluin <> | Subject | [PATCH] tracing/mm: val should be signed |
| |
If not signed the `val < 0' test below doesn't make sense. Also strict_strtol requires a long pointer.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- I think this is what was intended? please review.
diff --git a/kernel/trace/trace_mm.c b/kernel/trace/trace_mm.c index 4bc7fc0..9af2351 100644 --- a/kernel/trace/trace_mm.c +++ b/kernel/trace/trace_mm.c @@ -54,7 +54,8 @@ static ssize_t trace_mm_dump_range_write(struct file *filp, const char __user *ubuf, size_t cnt, loff_t *ppos) { - unsigned long val, start, end; + unsigned long start, end; + long val; char buf[64]; int ret;
| ![\](/images/icornerr.gif) |