Messages in this thread Patch in this message | | | From | KOSAKI Motohiro <> | Subject | [cleanup][PATCH 1/2] mlock_vma_pages_range() never return negative value | Date | Mon, 28 Dec 2009 11:45:58 +0900 (JST) |
| |
Currently, mlock_vma_pages_range() never return negative value. Then, we can remove some worthless error check.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/mmap.c | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c index 64e0b04..826b0ec 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1247,12 +1247,7 @@ out: mm->total_vm += len >> PAGE_SHIFT; vm_stat_account(mm, vm_flags, file, len >> PAGE_SHIFT); if (vm_flags & VM_LOCKED) { - /* - * makes pages present; downgrades, drops, reacquires mmap_sem - */ long nr_pages = mlock_vma_pages_range(vma, addr, addr + len); - if (nr_pages < 0) - return nr_pages; /* vma gone! */ mm->locked_vm += (len >> PAGE_SHIFT) - nr_pages; } else if ((flags & MAP_POPULATE) && !(flags & MAP_NONBLOCK)) make_pages_present(addr, addr + len); @@ -1730,8 +1725,7 @@ find_extend_vma(struct mm_struct *mm, unsigned long addr) if (!prev || expand_stack(prev, addr)) return NULL; if (prev->vm_flags & VM_LOCKED) { - if (mlock_vma_pages_range(prev, addr, prev->vm_end) < 0) - return NULL; /* vma gone! */ + mlock_vma_pages_range(prev, addr, prev->vm_end); } return prev; } @@ -1759,8 +1753,7 @@ find_extend_vma(struct mm_struct * mm, unsigned long addr) if (expand_stack(vma, addr)) return NULL; if (vma->vm_flags & VM_LOCKED) { - if (mlock_vma_pages_range(vma, addr, start) < 0) - return NULL; /* vma gone! */ + mlock_vma_pages_range(vma, addr, start); } return vma; } -- 1.6.5.2
| |