Messages in this thread Patch in this message | | | Date | Sun, 27 Dec 2009 22:27:44 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH 4/5] drivers/net/can: Correct NULL test |
| |
From: Julia Lawall <julia@diku.dk>
Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x,y; statement S; @@
x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/net/can/mcp251x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c --- a/drivers/net/can/mcp251x.c +++ b/drivers/net/can/mcp251x.c @@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(s goto error_tx_buf; } priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL); - if (!priv->spi_tx_buf) { + if (!priv->spi_rx_buf) { ret = -ENOMEM; goto error_rx_buf; }
| |