Messages in this thread Patch in this message | | | Date | Tue, 22 Dec 2009 21:32:07 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH 4/6] drivers/scsi/aacraid: Correct use after free |
| |
From: Julia Lawall <julia@diku.dk>
Move the kfree after the print statement that uses the freed structure.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x,e; identifier f; iterator I; statement S; @@
*kfree(x); ... when != &x when != x = e when != I(x,...) S *x->f // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/scsi/aacraid/commctrl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c index 0391d75..2870c16 100644 --- a/drivers/scsi/aacraid/commctrl.c +++ b/drivers/scsi/aacraid/commctrl.c @@ -655,9 +655,9 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) /* Does this really need to be GFP_DMA? */ p = kmalloc(usg->sg[i].count,GFP_KERNEL|__GFP_DMA); if(!p) { - kfree (usg); dprintk((KERN_DEBUG"aacraid: Could not allocate SG buffer - size = %d buffer number %d of %d\n", usg->sg[i].count,i,usg->count)); + kfree(usg); rcode = -ENOMEM; goto cleanup; }
| |