lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drop 80-character limit in checkpatch.pl
On Thu, 17 Dec 2009, Bartlomiej Zolnierkiewicz wrote:

> > > I like this patch, this is actually what I wanted to do.
> >
> > I have nothing against a switch, but it had better default to off.
> >
> > The whole 80-char limit is insane. It results in insane "fixes". Just
> > about every time somebody "improves" a patch due to the warning, the
> > result is worse than the original patch.
>
> Examples? :)

balance_leaf() in fs/reiserfs/do_balan.c

Example picked totally at random:

set_le_ih_k_offset(ih,
le_ih_k_offset(ih) +
(tb->
lbytes <<
(is_indirect_le_ih
(ih) ? tb->tb_sb->
s_blocksize_bits -
UNFM_P_SHIFT :
0)));

See how everything is nicely aligned to 80 cols?


Generally, don't look at this function after having a good lunch you want
to keep. You have been warned.

--
Jiri Kosina
SUSE Labs, Novell Inc.



\
 
 \ /
  Last update: 2009-12-18 14:07    [W:0.080 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site