Messages in this thread | | | Subject | Re: [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space | From | "H. Peter Anvin" <> | Date | Tue, 15 Dec 2009 12:00:36 -0800 |
| |
That's nice. It should be in the code, not in the commit message.
"Borislav Petkov" <borislav.petkov@amd.com> wrote:
>On Tue, Dec 15, 2009 at 08:31:50PM +0100, Ingo Molnar wrote: >> >> * Andreas Herrmann <herrmann.der.user@googlemail.com> wrote: >> >> > + rdmsrl(0xc001100c, value); >> >> Dont we want some nice, meaningfully named symbolic constant here, instead of >> 0xc001100c? > >The MSR name is actually in the commit msg, maybe something like >MSR_F10H_NODE_ID. > >-- >Regards/Gruss, >Boris. > >Operating | Advanced Micro Devices GmbH > System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany > Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni > Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München > (OSRC) | Registergericht München, HRB Nr. 43632 >
-- Sent from my mobile phone. Please excuse any lack of formatting. | |