lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space
From
Date
That's nice.  It should be in the code, not in the commit message.

"Borislav Petkov" <borislav.petkov@amd.com> wrote:

>On Tue, Dec 15, 2009 at 08:31:50PM +0100, Ingo Molnar wrote:
>>
>> * Andreas Herrmann <herrmann.der.user@googlemail.com> wrote:
>>
>> > + rdmsrl(0xc001100c, value);
>>
>> Dont we want some nice, meaningfully named symbolic constant here, instead of
>> 0xc001100c?
>
>The MSR name is actually in the commit msg, maybe something like
>MSR_F10H_NODE_ID.
>
>--
>Regards/Gruss,
>Boris.
>
>Operating | Advanced Micro Devices GmbH
> System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
> Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
> (OSRC) | Registergericht München, HRB Nr. 43632
>

--
Sent from my mobile phone. Please excuse any lack of formatting.
\
 
 \ /
  Last update: 2009-12-15 21:07    [W:0.143 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site