lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING
On Fri, Dec 11, 2009 at 05:59:06PM +0800, Li Zefan wrote:
> MATCH_FULL matching for PTR_STRING is not working correctly:
>
> # echo 'func == vt' > events/bkl/lock_kernel/filter
> # echo 1 > events/bkl/lock_kernel/enable
> ...
> # cat trace
> Xorg-1484 [000] 1973.392586: lock_kernel: ... func=vt_ioctl()
> gpm-1402 [001] 1974.027740: lock_kernel: ... func=vt_ioctl()
>
> We should pass to regex.match(..., len) the length (including '\0')
> of the source string instead of the length of the pattern string.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>


This patch is cool but it seems to also break middle and end
matching (at least what was working with end matching :)

I know you fix that in the subsequent patches, but please
avoid that. A fix should not bring another known bug,
event if it's fixed in the same batch.

Thanks.



\
 
 \ /
  Last update: 2009-12-11 13:11    [W:0.094 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site