Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 8 Jan 2009 09:18:53 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: + kernel-trace-ring_bufferc-use-div_round_up-fix.patch added to -mm tree |
| |
On Wed, 7 Jan 2009, akpm@linux-foundation.org wrote:
> > The patch titled > kernel-trace-ring_bufferc-use-div_round_up-fix > has been added to the -mm tree. Its filename is > kernel-trace-ring_bufferc-use-div_round_up-fix.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find > out what to do about this > > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ > > ------------------------------------------------------ > Subject: kernel-trace-ring_bufferc-use-div_round_up-fix > From: Andrew Morton <akpm@linux-foundation.org> > > oops > > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > kernel/trace/ring_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN kernel/trace/ring_buffer.c~kernel-trace-ring_bufferc-use-div_round_up-fix kernel/trace/ring_buffer.c > --- a/kernel/trace/ring_buffer.c~kernel-trace-ring_bufferc-use-div_round_up-fix > +++ a/kernel/trace/ring_buffer.c > @@ -150,7 +150,7 @@ rb_event_length(struct ring_buffer_event > > case RINGBUF_TYPE_DATA: > if (event->len) > - length = event->len / RB_ALIGNMENT; > + length = event->len * RB_ALIGNMENT;
OK, I see you spotted the mistake ;-)
-- Steve
> else > length = event->array[0]; > return length + RB_EVNT_HDR_SIZE; > _ >
| ![\](/images/icornerr.gif) |