lkml.org 
[lkml]   [2009]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3)
On Thu, Jan 29, 2009 at 12:18:07AM +0000, Adrian McMenamin wrote:
> + if (!(mdev->function & MAPLE_FUNC_KEYBOARD)) {
> + error = EINVAL;
> + goto fail;
> + }
>
What is this all about? If the function doesn't match, you should never
enter the probe routine in the first place. The bus code should already
get this right.


\
 
 \ /
  Last update: 2009-01-29 04:03    [W:0.034 / U:4.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site