lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 22/24] i386: add TRACE_IRQS_OFF for the nmi
Date

On Mon, 12 Jan 2009 19:43:35 +0100, "Peter Zijlstra"
<peterz@infradead.org> said:
> On Mon, 2009-01-12 at 19:39 +0100, Ingo Molnar wrote:
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > On Tue, 2008-09-09 at 21:56 +0200, heukelum@fastmail.fm wrote:
> > > > From: Alexander van Heukelum <heukelum@fastmail.fm>
> > > >
> > > > At this point interrupts are off, so let's inform the tracing
> > > > code of that fact before calling into C.
> > >
> > > Sorry but this is an obvious dud, lockdep (and thus the irq state
> > > tracer) aren't nmi safe.
> > >
> > > Ingo, please revert, as people are already seeing lockdep warnings due
> > > to this.
> >
> > done - reverted it in tip/x86/urgent, see the commit below. Is that all
> > that we need, wasnt there a 64-bit side done too?
>
> I had a _very_ quick peek but couldn't fine one, Alexander, does your
> memory go back that far? :-)

Git helped a bit, I must admit. The 64-bit version does not include
TRACE_IRQS_ON/TRACE_IRQS_OFF in the nmi handler. The comment above
"ENTRY(paranoid_exit)" in entry_64.S should be updated, though. That
code is not used for NMIs.

The revert is obviously the correct thing to do, but a comment would
not hurt here either.

Greetings,
Alexander
--
Alexander van Heukelum
heukelum@fastmail.fm

--
http://www.fastmail.fm - Access your email from home and the web



\
 
 \ /
  Last update: 2009-01-12 21:53    [W:0.237 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site