lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 22/24] i386: add TRACE_IRQS_OFF for the nmi
From
Date
On Mon, 2009-01-12 at 19:39 +0100, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Tue, 2008-09-09 at 21:56 +0200, heukelum@fastmail.fm wrote:
> > > From: Alexander van Heukelum <heukelum@fastmail.fm>
> > >
> > > At this point interrupts are off, so let's inform the tracing
> > > code of that fact before calling into C.
> >
> > Sorry but this is an obvious dud, lockdep (and thus the irq state
> > tracer) aren't nmi safe.
> >
> > Ingo, please revert, as people are already seeing lockdep warnings due
> > to this.
>
> done - reverted it in tip/x86/urgent, see the commit below. Is that all
> that we need, wasnt there a 64-bit side done too?

I had a _very_ quick peek but couldn't fine one, Alexander, does your
memory go back that far? :-)




\
 
 \ /
  Last update: 2009-01-12 19:47    [W:0.084 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site