Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected | Date | Wed, 1 Oct 2008 10:44:13 +1000 |
| |
On Wednesday 01 October 2008 02:46:59 Linus Torvalds wrote: > Quite frankly, I personally do hate typedefs that end up being pointers, > and used as pointers, without showing that in the source code. ... > I'm now a bit more leery about this whole thing just > because the typedef ends up hiding so much - it doesn't just hide the > basic type, it hides a very basic *code* issue.
Yes, this is why my version of the rework moved away from typedefs, except for the special case of "cpumask_var_t" for stack vars where this trick is really desired.
Everywhere else, the code becomes nice and clear: struct cpumask *.
Cheers, Rusty.
| |