Messages in this thread | | | Subject | Re: [PATCH] slub: reduce total stack usage of slab_err & object_err | From | Matt Mackall <> | Date | Tue, 30 Sep 2008 19:02:42 -0500 |
| |
On Tue, 2008-09-30 at 17:20 +0100, Richard Kennedy wrote: > Yes, using vprintk is better but you still have this path : > ( with your patch applied) > > object_err -> slab_bug(208) -> printk(216) > instead of > object_err -> slab_bug_message(8) -> printk(216) > > unfortunately the overhead for having var_args is pretty big, at least > on x86_64. I haven't measured it on 32 bit yet.
Looks like this got fixed for x86_64 in gcc 4.4. For most other arches, the overhead should be reasonable.
-- Mathematics is the supreme nostalgia of our time.
| |