| Date | Fri, 26 Sep 2008 14:06:02 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH 2/12] memcg move charege() call to swapped-in page under lock_page() |
| |
KAMEZAWA Hiroyuki wrote: > While page-cache's charge/uncharge is done under page_lock(), swap-cache > isn't. (anonymous page is charged when it's newly allocated.) > > This patch moves do_swap_page()'s charge() call under lock. This helps > us to avoid to charge already mapped one, unnecessary calls. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Seems reasonable to me
Just one quick comment though, as a result of this change, mark_page_accessed is now called with PageLock held, I suspect you would want to move that call prior to lock_page().
-- Balbir
|