Messages in this thread | | | Date | Fri, 26 Sep 2008 10:22:43 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 9/12] memcg allocate all page_cgroup at boot |
| |
On Fri, 26 Sep 2008 10:17:54 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 25 Sep 2008 11:40:47 -0700 > Dave Hansen <dave@linux.vnet.ibm.com> wrote: > > > On Thu, 2008-09-25 at 15:32 +0900, KAMEZAWA Hiroyuki wrote: > > > @@ -949,6 +953,11 @@ struct mem_section { > > > > > > /* See declaration of similar field in struct zone */ > > > unsigned long *pageblock_flags; > > > +#ifdef CONFIG_CGROUP_MEM_RES_CTLR > > > + /* see page_cgroup.h */ > > > + struct page_cgroup *page_cgroup; > > > + unsigned long pad; > > > +#endif > > > }; > > > > I thought the use of this variable was under the > > > > +#ifdef CONFIG_FLAT_NODE_MEM_MAP > > > > options. Otherwise, we unconditionally bloat mem_section, right? > > > Hmmm......Oh, yes ! nice catch. > > Thanks, I'll fix.
But in reality, this is under CONFIG_SPARSEMEM and if CONFIG_SPARSEMEM, FLAT_NODE_MEM_MAP is not true (I think). Hmm..Maybe I shouldn't use checking CONFIG_FLAT_NODE_MEM_MAP and should just use CONFIG_SPARSEMEM check. I'll rewrite.
Thanks, -Kame
| |