Messages in this thread Patch in this message | | | Date | Mon, 22 Sep 2008 22:58:47 -0700 | From | Ravikiran G Thirumalai <> | Subject | [PATCH] x86: Fix 27-rc crash on vsmp due to paravirt during module load |
| |
27-rc fails to boot up if configured to use modules. Turns out vsmp_patch was marked __init, and vsmp_patch being the pvops 'patch' routine for vsmp, a call to vsmp_patch just turns out to execute a code page with series of 0xcc (POISON_FREE_INITMEM -- int3). Since apply_paravirt can only be called during init/module load, make vsmp_patch with "__init_or_module"
Please apply
Thanks, Kiran ---
vsmp_patch has been marked with __init ever since pvops, however, apply_paravirt can be called during module load causing calls to freed memory location.
Since apply_paravirt can only be called during bootup and module load, mark vsmp patch with "__init_or_module"
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Index: linux-2.6/arch/x86/kernel/vsmp_64.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/vsmp_64.c 2008-09-19 11:37:54.000000000 -0700 +++ linux-2.6/arch/x86/kernel/vsmp_64.c 2008-09-21 15:50:18.000000000 -0700 @@ -61,7 +61,7 @@ native_restore_fl((flags | X86_EFLAGS_IF) & (~X86_EFLAGS_AC)); } -static unsigned __init vsmp_patch(u8 type, u16 clobbers, void *ibuf, +static unsigned __init_or_module vsmp_patch(u8 type, u16 clobbers, void *ibuf, unsigned long addr, unsigned len) { switch (type) {
| |