| Subject | Re: [RFC v5][PATCH 8/8] Dump open file descriptors | From | Dave Hansen <> | Date | Tue, 16 Sep 2008 08:54:46 -0700 |
| |
On Sat, 2008-09-13 at 19:06 -0400, Oren Laadan wrote: > > +static int > +cr_write_fd_ent(struct cr_ctx *ctx, struct files_struct *files, int > fd) > +{ > + struct cr_hdr h; > + struct cr_hdr_fd_ent *hh = cr_hbuf_get(ctx, sizeof(*hh)); > + struct file *file = NULL; > + struct fdtable *fdt; > + int coe, objref, new, ret; > + > + rcu_read_lock(); > + fdt = files_fdtable(files); > + file = fcheck_files(files, fd); > + if (file) { > + coe = FD_ISSET(fd, fdt->close_on_exec); > + get_file(file); > + } > + rcu_read_unlock(); > + > + /* sanity check (although this shouldn't happen) */ > + if (!file) > + return -EBADF; > + > + new = cr_obj_add_ptr(ctx, (void *) file, &objref, CR_OBJ_FILE, 0);
Dude, you don't need to cast to void*.
-- Dave
|