| Subject | Re: [RFC v5][PATCH 2/8] General infrastructure for checkpoint restart | From | Dave Hansen <> | Date | Mon, 15 Sep 2008 11:02:30 -0700 |
| |
On Sat, 2008-09-13 at 19:06 -0400, Oren Laadan wrote: > > +void *cr_hbuf_get(struct cr_ctx *ctx, int n) > +{ > + void *ptr; > + > + BUG_ON(ctx->hpos + n > CR_HBUF_TOTAL); > + ptr = (void *) (((char *) ctx->hbuf) + ctx->hpos); > + ctx->hpos += n; > + return ptr; > +}
All of the casting here is unnecessary. 'void *' behaves like 'char *' when you do arithmetic on it.
I really do detest having a memory allocator BUG_ON() when it runs out of space.
-- Dave
|