Messages in this thread | | | Subject | Re: [PATCHv3] leds-pca955x: Add proper error handling and fix bogus memory handling | From | Nate Case <> | Date | Fri, 08 Aug 2008 11:49:30 -0500 |
| |
On Fri, 2008-08-08 at 09:27 +0200, Sven Wegener wrote: > Here's a slightly updated patch, with some changes I had forgotten. > Shouldn't change the logic at all. > > - Another 32 -> sizeof() conversion > - Move the unregister code to where we also free the memory on failure > > And one more > > - cancel_work_sync() when unregistering on failure
This looks good to me. I won't be able to test it until Monday though.
-- Nate Case <ncase@xes-inc.com>
| |