lkml.org 
[lkml]   [2008]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv3] leds-pca955x: Add proper error handling and fix bogus memory handling
From
Date
On Fri, 2008-08-08 at 09:27 +0200, Sven Wegener wrote:
> Here's a slightly updated patch, with some changes I had forgotten.
> Shouldn't change the logic at all.
>
> - Another 32 -> sizeof() conversion
> - Move the unregister code to where we also free the memory on failure
>
> And one more
>
> - cancel_work_sync() when unregistering on failure

This looks good to me. I won't be able to test it until Monday though.

--
Nate Case <ncase@xes-inc.com>



\
 
 \ /
  Last update: 2008-08-08 18:53    [W:0.261 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site