Messages in this thread | | | Subject | Re: [PATCHv3] leds-pca955x: Add proper error handling and fix bogus memory handling | From | Nate Case <> | Date | Tue, 12 Aug 2008 15:18:18 -0500 |
| |
On Fri, 2008-08-08 at 09:27 +0200, Sven Wegener wrote: > Check the return value of led_classdev_register and unregister all > registered > devices, if registering one device fails. Also the dynamic memory > handling is > totally bogus. You can't allocate multiple chunks via kzalloc() and > expect them > to be in order later. > > Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Acked-by: Nate Case <ncase@xes-inc.com>
Thanks for the fix. It looks correct and I tested it on my board with a pca9553. I also confirmed that the original driver would in fact kernel Oops if compiled as a module and you rmmod it. With this fix, I can repeatedly insmod/rmmod successfully.
-- Nate Case <ncase@xes-inc.com>
| |