Messages in this thread | | | Date | Mon, 4 Aug 2008 22:18:22 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API. |
| |
On Mon, Aug 04, 2008 at 05:35:07AM -0400, Austin Zhang wrote: > > +static int crc32c_intel_cra_init(struct crypto_tfm *tfm) > +{ > + u32 *key = crypto_tfm_ctx(tfm); > + > + *key = ~0; > + > + tfm->crt_ahash.reqsize = sizeof(u32); > + > + if (cpu_has_xmm4_2) > + return 0; > + else > + return -1; > +}
This check needs to be moved to the module init function and if it fails the module should not register the algorithm.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |