Messages in this thread | | | Date | Mon, 4 Aug 2008 22:17:30 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API. |
| |
On Mon, Aug 04, 2008 at 03:13:34PM +0100, David Woodhouse wrote: > > > +static int __init crc32c_intel_mod_init(void) > > +{ > > + return crypto_register_alg(&alg); > > +} > > + > > Am I missing something here, or are you registering the crypto algorithm > _unconditionally_ and then just causing init requests for it to fail on > older hardware? Wouldn't it be better to register the driver _only_ > when the hardware is capable? Or at least "if at least one cpu is > capable".
Yes I think this is a show-stopper :)
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |